Allow Marking Enigma Souls by Zone - #2539
Open
qb42 wants to merge 5 commits into
Open
Conversation
1. EnigmaSouls.shouldRender already checks highlightFoundEnigmaSouls. 2. filtering by shouldRender makes running with asFound=true fail silently unless highlightFoundEnigmaSouls is set.
qb42
force-pushed
the
pr-enigma-helper-zones-26.2
branch
from
July 15, 2026 05:08
0b75b9d to
70e8023
Compare
Author
|
I switched back to the original format for the found file. I have some ideas for an overhaul of all 3 classes that use ProfileAwareWaypoint and I think it's best to not have multiple format changes. Assuming you're open to it, I would like to switch all the found files to use the same double uuid format as ProfiledData, as well as centralizing duplicated logic and improving the feedback from commands. This would be as a later PR, to be clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
markZoneFound/markSoulsMissingsubcommands to/skyblocker rift enigmaSouls, as a rough parallel to/skyblocker fairySouls markAllInCurrentIsland*. I made the zone an argument instead of using the current zone both because there doesn't seem to be an existing way to get the current rift zone, and because some souls are located in a different zone than the chapter they are in in the rift guide (Tel Kar is physically in the Wyld Woods but his soul is in the Black Lagoon chapter).I did add the name of each soul as well as its zone, even though it's currently only used for debug messages. I would like to print the name in the markClosest chat messages as well, but I'm a bit hesitant to touch existing translation keys, so I'll leave that for the future.
I also included a bug fix and some sanity-checks so that profile names in found_enigma_souls.json don't get screwed up if the commands are run outside the rift.
Important notes:
This pr includes a significant change to the format of found_enigma_souls.json, old files will be converted to the new format on first load. If you prefer to keep the original format instead, I can make that work, just let me know.changed below